Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): support new AI Tasks spec #655

Merged
merged 29 commits into from
Sep 5, 2024
Merged

feat(task): support new AI Tasks spec #655

merged 29 commits into from
Sep 5, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Aug 13, 2024

Because

  • We are going to adopt new AI Tasks spec and remove data serialization between model-backend and ray-server
  • We are going to use google.protobuf.struct as task input/output and validate them against jsonschema

This commit

  • remove input/output data processing and serialization
  • adopt new protobuf to replace task input message type to structpb
  • add jsonschema load and validation

resolves INS-5269
resolves INS-5457
resolves INS-5460
resolves INS-5461
resolves INS-5424

internal/jsonref/ref.go Dismissed Show dismissed Hide dismissed
@heiruwu heiruwu changed the title feat(task): feat(task): support new AI Tasks spec Aug 13, 2024
@heiruwu heiruwu force-pushed the heiru/INS-5269 branch 2 times, most recently from 43d01bb to f1cad62 Compare August 20, 2024 16:15
@heiruwu heiruwu force-pushed the heiru/INS-5269 branch 2 times, most recently from 1ead054 to b96c09b Compare August 29, 2024 03:54
@heiruwu heiruwu marked this pull request as ready for review September 2, 2024 05:20
@heiruwu heiruwu marked this pull request as draft September 2, 2024 05:20
@heiruwu heiruwu self-assigned this Sep 2, 2024
@heiruwu heiruwu marked this pull request as ready for review September 2, 2024 15:06
Copy link

linear bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 1.47493% with 668 lines in your changes missing coverage. Please review.

Project coverage is 3.70%. Comparing base (f519c82) to head (438c047).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
internal/jsonref/ref.go 0.00% 299 Missing ⚠️
pkg/handler/trigger.go 0.00% 184 Missing ⚠️
pkg/datamodel/jsonschema.go 0.00% 63 Missing ⚠️
pkg/service/service.go 0.00% 46 Missing ⚠️
pkg/worker/workflow.go 26.92% 17 Missing and 2 partials ⚠️
pkg/ray/rayserver/ray.pb.go 15.00% 17 Missing ⚠️
cmd/main/main.go 0.00% 11 Missing ⚠️
pkg/ray/ray.go 0.00% 8 Missing ⚠️
pkg/service/convert.go 0.00% 8 Missing ⚠️
cmd/worker/main.go 0.00% 6 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #655      +/-   ##
========================================
+ Coverage   3.41%   3.70%   +0.29%     
========================================
  Files         64      62       -2     
  Lines      13780   10682    -3098     
========================================
- Hits         470     396      -74     
+ Misses     13263   10233    -3030     
- Partials      47      53       +6     
Flag Coverage Δ
unittests 3.70% <1.47%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit e34d4e1 into main Sep 5, 2024
21 checks passed
@heiruwu heiruwu deleted the heiru/INS-5269 branch September 5, 2024 09:53
heiruwu pushed a commit that referenced this pull request Sep 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.30.0-alpha](v0.29.0-alpha...v0.30.0-alpha)
(2024-09-10)


### Features

* **task:** support new AI Tasks spec
([#655](#655))
([e34d4e1](e34d4e1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

2 participants