Use deployment-status ref instead of sha #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cou929-subscribe-certain-labels #915 +/- ##
===================================================================
+ Coverage 97.21% 97.22% +<.01%
===================================================================
Files 157 157
Lines 2623 2627 +4
Branches 356 358 +2
===================================================================
+ Hits 2550 2554 +4
Misses 69 69
Partials 4 4 |
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 97.33% 97.34% +<.01%
==========================================
Files 154 154
Lines 2481 2487 +6
Branches 321 323 +2
==========================================
+ Hits 2415 2421 +6
Misses 62 62
Partials 4 4 |
dennissivia
added
topic:deployments
wilhelmklopp
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
This is an awesome improvement! 🎉 🌈
When the integrator that created the deployment status provided a ref,
that is different from the commit sha, that ref is now displayed instead
of the short sha.
✨
Do you have an example screenshot of what this looks like in Slack?
When the integrator that created the deployment status provided a ref, that is different from the commit sha, that ref is now displayed instead of the short sha. This addresses the issue discussed in #98 and #85. I think the next step would be doing an actual API request to fetch the branches, but his change is a 0-cost improvement and (almost) 0-effort improvement that allows us to gather metrics about custom ref adoption and maybe this already solves the problem. Refs #85, #98
Most importantly we are now showing showing the ref and the shortSha and not only the ref to improve the UX for certain use-cases.
dennissivia
force-pushed
the
improve-deployment-message
branch
from
b27de00 to
f87d8ea
Compare
dennissivia
changed the base branch from
cou929-subscribe-certain-labels
to
master
dennissivia
removed
the
status:Do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the integrator that created the deployment status provided a ref,
that is different from the commit sha, that ref is now displayed instead
of the short sha.
This addresses the issue discussed in #98 and #85.
I think the next step would be doing an actual API request to fetch the
branches, but his change is a 0-cost improvement and (almost) 0-effort
improvement that allows us to gather metrics about custom ref adoption
and maybe this already solves the problem.
Screenshots
Before
After
Closes #85, #98