Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase jest timeouts to stablize unfurl CI tests #920

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

dennissivia
Copy link
Contributor

Actions CI tests run into the jest default timeout of 5 seconds on
almost all builds. This increases the value to 10 seconds, similarly to
other integration tests we have.

GitHub CI is βœ… . It works πŸ‘

Actions CI tests run into the jest default timeout of 5 seconds on
almost all builds. This increases the value to 10 seconds, similarly to
other integration tests we have.
@dennissivia dennissivia requested a review from a team August 22, 2019 13:05
@jules2689
Copy link

Actions CI tests run into the jest default timeout of 5 seconds on almost all builds.

What do you mean by this? How does Actions CI run into a timeout of what it's running?

Copy link

@jules2689 jules2689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM

@dennissivia
Copy link
Contributor Author

dennissivia commented Aug 26, 2019

Actions CI tests run into the jest default timeout of 5 seconds on almost all builds.

What do you mean by this? How does Actions CI run into a timeout of what it's running?

The integration tests seem to be affected by the hardware performance of the system running then. Even though all requests are (should be) stubbed, the slower the system, the longer it takes our tests to be executed(nock-mocks, redis-calls, database-calls and probot logic).
This is even observable on the local system. The slower your system gets, the higher the frequency of failing tests, due to exceeding the jestTimeout.
Travis is a little slower than our new MacBooks and because of that we sometimes run into jest timeouts on Travis but only very rarely on local setups.
GitHub CI executes slower than Travis and fails even more frequently with jestTimeout errors. I am not really sure, why we are running into these errors in the first place.
I assume it might be IO-bound and data store related, but I am not sure.
Understanding and fixing this might be worth it (eventually).

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #920 into master will increase coverage by 20.44%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #920       +/-   ##
===========================================
+ Coverage   76.89%   97.34%   +20.44%     
===========================================
  Files         154      154               
  Lines        2489     2487        -2     
  Branches      324      323        -1     
===========================================
+ Hits         1914     2421      +507     
+ Misses        499       62      -437     
+ Partials       76        4       -72

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #920 into master will increase coverage by 20.44%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #920       +/-   ##
===========================================
+ Coverage   76.89%   97.34%   +20.44%     
===========================================
  Files         154      154               
  Lines        2489     2489               
  Branches      324      324               
===========================================
+ Hits         1914     2423      +509     
+ Misses        499       62      -437     
+ Partials       76        4       -72

@dennissivia dennissivia merged commit 03f7d01 into master Aug 26, 2019
@dennissivia dennissivia deleted the inrease-jest-timeout-for-unfurl branch August 26, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants