-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase jest timeouts to stablize unfurl CI tests #920
Conversation
Actions CI tests run into the jest default timeout of 5 seconds on almost all builds. This increases the value to 10 seconds, similarly to other integration tests we have.
What do you mean by this? How does Actions CI run into a timeout of what it's running? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM
The integration tests seem to be affected by the hardware performance of the system running then. Even though all requests are (should be) stubbed, the slower the system, the longer it takes our tests to be executed( |
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
===========================================
+ Coverage 76.89% 97.34% +20.44%
===========================================
Files 154 154
Lines 2489 2487 -2
Branches 324 323 -1
===========================================
+ Hits 1914 2421 +507
+ Misses 499 62 -437
+ Partials 76 4 -72 |
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
===========================================
+ Coverage 76.89% 97.34% +20.44%
===========================================
Files 154 154
Lines 2489 2489
Branches 324 324
===========================================
+ Hits 1914 2423 +509
+ Misses 499 62 -437
+ Partials 76 4 -72 |
Actions CI tests run into the jest default timeout of 5 seconds on
almost all builds. This increases the value to 10 seconds, similarly to
other integration tests we have.
GitHub CI is β . It works π