Don't prompt for unfurl without permission #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While processing the `link_shared` Slack event, we need to check if the integration is installed in the current channel before creating an ephemeral message for private repos. Otherwise the attempt to prompt the user will result in a `no_permission` error from Slack. Closes #922
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 97.34% 97.34% +<.01%
==========================================
Files 154 154
Lines 2487 2489 +2
Branches 323 324 +1
==========================================
+ Hits 2421 2423 +2
Misses 62 62
Partials 4 4 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 97.34% 97.34% +<.01%
==========================================
Files 154 154
Lines 2487 2489 +2
Branches 323 324 +1
==========================================
+ Hits 2421 2423 +2
Misses 62 62
Partials 4 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing the
link_sharedSlack event, we need to check if theintegration is installed in the current channel before creating an
ephemeral message for private repos.
Otherwise the attempt to prompt the user will result in a
no_permissionerror from Slack.Closes #922