-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go-github to V65 #2359
Conversation
ff8e06e
to
2be7b99
Compare
Co-authored-by: Ze Peng <[email protected]>
go.mod
Outdated
github.com/google/go-github/v63 v63.0.0 | ||
github.com/google/go-github/v64 v64.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to bump this to v65 and remove the indirect below, running go mod tidy
should then also remove v64 from go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was rushing and missed this step, done now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@kfcampbell @nickfloyd (sorry just tagging some maintainers who recently approved PRs) can we get some eyes on this PR please. It helps unblock couple other PRs that is currently blocked requiring newer version of google/go-github |
@grahamhar @kfcampbell @nickfloyd This is has been open for over a month and blocking a few other PRs now, possible to have this merged or taken over by someone with bandwidth to do so? |
Apologies for the delay. I'm looking at this today and should have it merged in and shipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have attempted to run the checklist but some changes are being flagged in plan due to dependabot being enabled by default on the org in use. Is this due to the way new orgs have vulnerability_alerts on by default now for public repositories?
Example of failing test.
@grahamhar unfortunately this failure has crept into our main branch and will need to be dealt with separately. Fortunately for this case, this means we can take this PR as-is now.
As always, thank you for your attention to the testing in this provider.
Resolves #2358
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
I have attempted to run the checklist but some changes are being flagged in plan due to dependabot being enabled by default on the org in use. Is this due to the way new orgs have vulnerability_alerts on by default now for public repositories?
Example of failing test.