fix multiple device bug #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiweiZhang1
approved these changes
Nov 14, 2024
| @@ -906,7 +906,7 @@ def compile_func_on_hpu(func): | |||
|
|
|||
|
|
|||
| def compile_func_on_cuda_or_cpu(func, enable_torch_compile): | |||
| if enable_torch_compile or TORCH_VERSION_AT_LEAST_2_6_PRE_RELEASE: | |||
| if enable_torch_compile or (TORCH_VERSION_AT_LEAST_2_6_PRE_RELEASE and enable_torch_compile!=False): | |||
There was a problem hiding this comment.
Can it be simplified to 'if enable_torch_compile' ?
There was a problem hiding this comment.
when enable_torch_compile is set to None and torch version is >=2.6, automatically set enable_torch_compile to True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.