Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

[NeuralChat] Fix UT TestClient.client=None issue #1398

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

letonghan
Copy link
Contributor

Type of Change

bug fix
API not changed

Description

Fix request.client=None issue using async UT.
fastapi.TestClient.client was set to None in
link:

Expected Behavior & Potential Risk

UT of test_photoai_api.py and test_askdoc_server.py will pass.

How has this PR been tested?

Local tested on SPR.

Dependency Change?

None

Copy link

github-actions bot commented Mar 20, 2024

⛈️ Required checks status: Has failure 🔴

Warning
If you do not have the access to re-run the CI-Summary bot, please contact VincyZhang for help. If you push a new commit, all of the workflow will be re-triggered.

Groups summary

🟢 Format Scan Tests workflow
Check ID Status Error details
format-scan (pylint) success
format-scan (bandit) success
format-scan (cloc) success
format-scan (cpplint) success

These checks are required after the changes to intel_extension_for_transformers/neural_chat/tests/ci/server/test_askdoc_server.py, intel_extension_for_transformers/neural_chat/tests/ci/server/test_photoai_api.py.

🔴 NeuralChat Unit Test
Check ID Status Error details
neuralchat-unit-test-baseline success
neuralchat-unit-test-PR-test success
Generate-NeuralChat-Report failure download

These checks are required after the changes to intel_extension_for_transformers/neural_chat/tests/ci/server/test_askdoc_server.py, intel_extension_for_transformers/neural_chat/tests/ci/server/test_photoai_api.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 360 minutes every 180 seconds. If you have any other questions, contact VincyZhang or XuehaoSun for help.

@letonghan letonghan changed the title [NeuralChat] [NeuralChat] Fix UT TestClient.client=None issue Mar 20, 2024
@VincyZhang
Copy link
Contributor

Coverage drop is due to code change but acceptable

@VincyZhang VincyZhang merged commit 494a571 into main Mar 20, 2024
9 of 10 checks passed
@VincyZhang VincyZhang deleted the letong/fix_testclient_ut branch March 20, 2024 05:54
a32543254 pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants