Restrict NPU allocator to case when NPU is selected. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-intel
force-pushed
the
jemartin/npu_allocator_fix
branch
2 times, most recently
from
21d9478 to
8b68aa7
Compare
MayureshV1
reviewed
Feb 5, 2025
| @@ -17,7 +17,7 @@ | |||
| message(FATAL_ERROR "OpenVINO 2024.5 and newer are supported. Please, use latest OpenVINO release") | |||
| endif() | |||
|
|
|||
| if(OpenVINO_VERSION VERSION_GREATER_EQUAL 2024.4) | |||
| if(onnxruntime_USE_OPENVINO_NPU AND (OpenVINO_VERSION VERSION_GREATER_EQUAL 2024.4)) | |||
There was a problem hiding this comment.
This fix mitigates the bug which was filed to run on CPU without NPU dependency.
If -use_openvino or -use_openvino CPU is used during build time, then RemoteTensor optimization for NPU will be disabled at runtime which could have a perf impact on models using Remote tensors. @sfatimar need to identify steps used to build OV EP for apps using NPU and investigate impact to existing apps.
|
I think this fix is not required as original issue is not being seen, @vthaniel to confirm https://jira.devtools.intel.com/browse/HAFP-2997 |
|
The change is handled as runtime option in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OVEP is currently always reporting the NPU allocator when OV is >= 2024.4. This change restricts reporting the NPU allocator only when NPU is selected in the configuration
Motivation and Context
Adds a second guard against exposing the allocator in the wrong scenario.