This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
set and test with default FS type #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PV must have the filesystem specified for Kubernetes < 1.20 to apply the FSGroup support (a heuristic in Kubernetes). external-provisioner >= 2.0.0 only adds that field if it knows about the default FS. Fixes: intel#644
When running commands inside a pod it is better to first change into /tmp before potentially extracting files, because the default directory is / and that might not be writable when the container isn't running as root.
This was broken for the default FS (intel#644).
There are cases where it really matters whether the storage class contains a FS type (kubernetes-csi/external-provisioner#328 (comment)). To cover that with our tests we need a storage class that has just the defaults. Explicitly setting reclaim policy and immediate binding also only makes sense to show that those options exists, which is covered by Kubernetes documentation. We better ensure that we really use the defaults by not even setting those.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated test reveals that ownership changing fails when using a storage class without explicit FS type. This gets fixed by adding the
--default-fstypeparameter to external-provisioner (kubernetes-csi/external-provisioner#328 (comment)).