Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg-qsv] add vp9e playback_seek test case #679

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

Hangjie22Coder
Copy link
Contributor

No description provided.

@Hangjie22Coder
Copy link
Contributor Author

Hi @uartie, can you review this for me?

lib/parameters.py Outdated Show resolved Hide resolved
test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
@Hangjie22Coder
Copy link
Contributor Author

Hi @uartie, thank you for your review. I have updated the code based on your suggestions.

test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
@Hangjie22Coder
Copy link
Contributor Author

Thank you for the review. I have revised the code to retain only rcmode, bitrate, fps, and seek as per your suggestion. The updated implementation has been tested and successfully passed. Please let me know if any further adjustments are needed.

test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
test/ffmpeg-qsv/encode/vp9.py Outdated Show resolved Hide resolved
@uartie uartie merged commit a88d221 into intel:master Sep 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants