Expose C-API's for some of the keyvalue qsort #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-devulap
force-pushed
the
postgres
branch
2 times, most recently
from
de74aee to
c21f0a4
Compare
sterrettm2
reviewed
Nov 27, 2024
|
|
||
| // declare function here, linker will find this when linked to | ||
| // libx86simdsortcpp.so | ||
| void keyvalue_qsort_float_sizet(float *, size_t *, size_t); |
There was a problem hiding this comment.
Should we add a header file for these declarations? They probably should be documented somewhere, definitely if there's no header file for them
|
|
||
| extern "C" { | ||
| XSS_EXPORT_SYMBOL | ||
| void keyvalue_qsort_float_uint32(float *key, uint32_t *val, uint32_t size) |
There was a problem hiding this comment.
Is there a reason why some of these functions take the size of the array as a uint32_t instead of a size_t? I'd prefer they all be the same if there's no reason for them not to be.
| x86simdsort::keyvalue_qsort(key, val, size, true); | ||
| } | ||
| XSS_EXPORT_SYMBOL | ||
| void keyvalue_qsort_float_sizet(float *key, size_t *val, size_t size) |
There was a problem hiding this comment.
I also think the argument type/function name of these being size_t is a little awkward. I think I would probably call them uint64; I guess that might not technically always be the same, if it was running on a 32-bit system. But I presume 64 bit unsigned integer is what is meant here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an example file to demonstrate how to use it.