Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reinstalling a template, do not change the data of blocks in the <changeset> tag of install file. #347

Closed
amalichev opened this issue Feb 15, 2017 · 3 comments
Labels
Milestone

Comments

@amalichev
Copy link
Contributor

The problem is with the attribute title
Example:

  1. Try to change the status of block in the install file of template and then reinstall.
  2. If the status is changed, try again.
<changeset>
	<block status="active" title="Sponsored cars for sale" position="verytop" sticky="0" pages="index">auto_sponsored</block>
<changeset>

<block> without the attribute title works well.

@vbezruchkin vbezruchkin added this to the 4.1.1 milestone Feb 15, 2017
@vbezruchkin
Copy link
Member

Just to clarify.

Title attributes are not processed correctly as we don't have title column.

Two ways to go.

  1. Update value through phrase and create correct phrase key
  2. Implement processing for multilingual fields

Second way is good to go, not now though.

@glebovsky
Copy link
Contributor

Also please check order attribute. It is ignored in the changeset.

@ghost ghost self-assigned this Feb 23, 2017
ghost pushed a commit that referenced this issue Feb 23, 2017
@amalichev
Copy link
Contributor Author

Tested. Works fine. Issue can be considered as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants