-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename parameter_overwite_by_rails_rule
to parameter_overwrite_by_rails_rule
#396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option has already been released in v5.0.0, so it would be a good to change it while maintaining backwards compatibility.
It would be a good to proceed as follows in stages.
- Add parameter_overwrite_by_rails_rule option to indicate to use it (or print a warning)
- Release the above as a minor version update
- Delete parameter_ overwrite _by_rails_rule during the next major version update
OK, I've added one more commit to support the "overwite" one as well, so please check it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r7kamura Thank you! Looks good!
I think this is a change that should be communicated to users, so could you add a description of the change in the CHANGELOG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
"overwite" is probably a typo for "overwrite" ?