Organize and update rubocop #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ❯ bundle exec rubocop Inspecting 81 files ................................................................................. 81 files inspected, no offenses detected The following RuboCop extension libraries are installed but not loaded in config: * rubocop-minitest * rubocop-rake ```
Closed
brandur
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop was fixed to an older version due to supporting Ruby 2.4 at that time. However, it currently supports versions 2.7 and above, so the version constraint has been removed. Additionally, unused and unnecessary extensions were removed, suppressing the following warnings.
base64 is loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
Although rubocop so far depends on base64, rubocop has not been added to the runtime dependency so far. So, rubocop will not work on Ruby heads with rubocop prior to v1.56.0. So it is a good to keep the version up to date.
https://github.com/interagent/committee/actions/runs/7624721002/job/20767482497?pr=404#step:4:5