Merge pull request #322 from interagent/add-zulu-time-helpers

Add Pliny::Helpers::ZuluTime to Serializers::Base

lib/pliny.rb

@@ -8,6 +8,7 @@
 require_relative "pliny/helpers/encode"
 require_relative "pliny/helpers/params"
 require_relative "pliny/helpers/serialize"
+require_relative "pliny/helpers/zulu_time"
 require_relative "pliny/log"
 require_relative "pliny/metrics/backends/logger"
 require_relative "pliny/metrics"

lib/pliny/helpers/zulu_time.rb

@@ -0,0 +1,7 @@
+module Pliny::Helpers
+  module ZuluTime
+    def zulu_time(time)
+      time ? time.getutc.strftime("%Y-%m-%dT%H:%M:%SZ") : nil
+    end
+  end
+end

lib/pliny/templates/serializer.erb

@@ -10,9 +10,9 @@
 <%=  ident %>class <%= modules.last %> < Serializers::Base
 <%=  ident %>  structure(:default) do |arg|
 <%=  ident %>    {
-<%=  ident %>      created_at: arg.created_at.try(:iso8601),
+<%=  ident %>      created_at: zulu_time(arg.created_at),
 <%=  ident %>      id:         arg.id,
-<%=  ident %>      updated_at: arg.updated_at.try(:iso8601),
+<%=  ident %>      updated_at: zulu_time(arg.updated_at)
 <%=  ident %>    }
 <%=  ident %>  end
 <%=  ident %>end

lib/template/lib/serializers/base.rb

@@ -1,5 +1,7 @@
 module Serializers
   class Base
+    extend Pliny::Helpers::ZuluTime
+
     @@structures = {}
 
     def self.structure(type, &blk)

spec/helpers/zulu_time_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+require "active_support/core_ext/numeric/time"
+
+describe Pliny::Helpers::ZuluTime do
+  context "zulu_time" do
+    class ZuluTimeTest
+      extend Pliny::Helpers::ZuluTime
+    end
+
+    it "it formats Time instances" do
+      formatted = ZuluTimeTest.zulu_time(Time.parse("2017-11-28T21:49:52.123+00:00"))
+      assert_equal "2017-11-28T21:49:52Z", formatted
+    end
+
+    it "it formats DateTime instances" do
+      formatted = ZuluTimeTest.zulu_time(DateTime.parse("2017-11-28T21:49:52.123+00:00"))
+      assert_equal "2017-11-28T21:49:52Z", formatted
+    end
+
+    it "when called with nil" do
+      assert_nil ZuluTimeTest.zulu_time(nil)
+    end
+  end
+end