Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: drop processing messages #28

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Feb 1, 2022

While it's useful for debugging, the latency on operations is low
enough that if we don't get a response in a few seconds, we know that
there's a problem, and otherwise acknowledging the message isn't
particularly useful and just makes it harder to look at slack channels
where pool toy is used.

@okwme
Copy link
Contributor

okwme commented Feb 1, 2022

the only time that it takes a long time is actually when a new user arrives, which is also kind of a premier moment for good status feedback. there should actually be a way to make slack remove the status message after the result message is delivered but i never figured it out.

i'd be happy to remove this feedback functionality but would be good to track the ideal scenario somehow... maybe i'll make an issue just so that it isn't lost.

@okwme
Copy link
Contributor

okwme commented Feb 1, 2022

got it tracked now : )

@okwme okwme merged commit 7b4f5b1 into master Feb 1, 2022
@okwme
Copy link
Contributor

okwme commented Feb 1, 2022

oh noooo the autodeploy failed:

======CMD======
source ~/.zshrc
killall -9 slackbot
cd ~/slackbot && git pull && go build
source ~/slackbot/.env
~/slackbot/slackbot &> ~/slackbot.log  &!

======END======
out: [oh-my-zsh] Would you like to update? [Y/n] 
out: [oh-my-zsh] You can update manually by running `omz update`
err: not interactive and can't open terminal
err: not interactive and can't open terminal
err: From https://github.com/interchainberlin/slackbot
err:    1bbb7ac..7b4f5b1  master     -> origin/master
err:  * [new branch]      output-drop-progress-message -> origin/output-drop-progress-message
err: error: Your local changes to the following files would be overwritten by merge:
err: 	main.go
err: Please commit your changes or stash them before you merge.
err: Aborting
==============================================
✅ Successfully executed commands to all host.
==============================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants