refactor: replace std::io::Error with custom OerError #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelephant
force-pushed
the
io-errors
branch
4 times, most recently
from
0af1137 to
6aaf4be
Compare
koivunej
reviewed
May 19, 2021
There was a problem hiding this comment.
I think this is looking great! The major question is to go with the added read_{u{8,16,32},exact} or just with bytes::Buf methods and have an oblig length check before deserialization.
I think the single big length check would be preferable, because afterwards the LLVM can probably see that the bytes::Buf methods cannot panic.
Regarding the failed exchange_rates.rs test... We might need to disable it, unless there was just some temporary issue.
Signed-off-by: bwty <[email protected]>
- Introduce `try_read_u8` in `BufOerExt` trait - Remove ByteOrder dep in packet, stream, service-util and ildcp - Add OerError to stream, btp and ccp - stream remove useless error var Signed-off-by: bwty <[email protected]> Signed-off-by: bwty <[email protected]>
- added methods in BufOerExt for check and read data into buf - remove bytesorder dependencies - rename previous try_read_u8 to read_u8 Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Co-authored-by: Joonas Koivunen <[email protected]> Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
koivunej
reviewed
May 20, 2021
koivunej
reviewed
May 20, 2021
koivunej
reviewed
May 20, 2021
koivunej
approved these changes
May 20, 2021
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: bwty <[email protected]>
koivunej
reviewed
May 21, 2021
koivunej
changed the title
|
Oki I understand that the PR is now ready to be merged but since it's already friday lets give this some more time. |
Open
pradovic
requested changes
May 21, 2021
6 tasks
Signed-off-by: Joonas Koivunen <[email protected]>
the comments on the test case bothered me after reading through them over and over again. Made the cases exhaustive by checking every other short buffer as well. Signed-off-by: Joonas Koivunen <[email protected]>
this will allow defining easily constants for more fields. Signed-off-by: Joonas Koivunen <[email protected]>
naming: most of the constants seem LEN not LENGTH Signed-off-by: Joonas Koivunen <[email protected]>
smaller than the Address::MIN_LEN constant. Signed-off-by: Joonas Koivunen <[email protected]>
I hope this doesn't duplicate some existing test ... I did try to look around for it. Signed-off-by: Joonas Koivunen <[email protected]>
the string contained a stringified version of chrono::Error, which wasn't much use, see the two cases of changed strings. Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
- more "Invalid Packet" -- these used to be mostly I/O Errors - use display instead of debug formatting Signed-off-by: Joonas Koivunen <[email protected]>
Signed-off-by: Joonas Koivunen <[email protected]>
|
Cannot get any reliable perf changes, but at least there's no more IO error, so this is a big win for readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove requirement to keep mapping
std::io::Errorinto different crates` error type.