Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI spec validation #724

Closed
adrianhopebailie opened this issue Nov 2, 2022 · 0 comments · Fixed by #726
Closed

OpenAPI spec validation #724

adrianhopebailie opened this issue Nov 2, 2022 · 0 comments · Fixed by #726
Assignees
@JoblersTune
Labels
good first issue Good for newcomers

Comments

@adrianhopebailie
Copy link
Collaborator

Per @wilsonianb suggestion in #684

OpenAPI spec validation should be added to GitHub Actions, a la:
https://github.com/interledger/open-payments/blob/1e3e118d8b22c5d2942f972e28ebf0f0114d04f5/.github/workflows/validate-openapi.yaml#L26-L32

Seems like it would go here (and the check would need to run fetch-schemas?):

rafiki/.github/workflows/lint_test_build.yml

Line 41 in 1b03f3e

auth:

I'm assuming where already covered with formatting

rafiki/.github/workflows/lint_test_build.yml

Line 19 in 1b03f3e

- run: pnpm checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoblersTune JoblersTune

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add validation for the OpenAPI specs to GitHub Actions interledger/rafiki
2 participants
@adrianhopebailie @JoblersTune