chore: add validation for the OpenAPI specs to GitHub Actions #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoblersTune
force-pushed
the
sj-openapi-spec-validation
branch
from
65bf293 to
70cc388
Compare
JoblersTune
force-pushed
the
sj-openapi-spec-validation
branch
from
70cc388 to
ecae287
Compare
|
@adrianhopebailie should the linting check apply to both the id-provider.yaml file as well as the resource-server.yaml? |
JoblersTune
force-pushed
the
sj-openapi-spec-validation
branch
from
e4b42b2 to
c2f0bc8
Compare
wilsonianb
reviewed
Nov 4, 2022
| echo "{\"extends\":[\"spectral:oas\",\"spectral:asyncapi\"]}" >> .spectral.json | ||
| - name: Validate Open API specs | ||
| run: | | ||
| npx @stoplight/spectral-cli lint ./packages/auth/openapi/*-server.yaml |
There was a problem hiding this comment.
should the linting check apply to both the id-provider.yaml file as well as the resource-server.yaml?
yes
| @@ -99,7 +99,7 @@ paths: | |||
| type: object | |||
| properties: | |||
| access: | |||
| $ref: ./schemas.yaml#/access | |||
| $ref: ./schemas.yaml#/components/schemas/access | |||
There was a problem hiding this comment.
Heads up, this is overlapping with:
JoblersTune
force-pushed
the
sj-openapi-spec-validation
branch
from
e30ec49 to
c29ba18
Compare
wilsonianb
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #number