feat(auth): use gnap error middleware on idp api #3094
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njlie
requested review from
BlairCurrey,
mkurapov,
sabineschaller and
oana-lolea
github-actions
bot
added
type: source
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
oana-lolea
previously approved these changes
Nov 11, 2024
mkurapov
reviewed
Nov 12, 2024
Comment on lines
+42
to
+47
| '500': | ||
| description: Internal Server Error |
There was a problem hiding this comment.
Would it be good to provide the actual GNAP response error objects in the IDP spec?
There was a problem hiding this comment.
I'll add them since it's a pretty bare PR as it is right now
mkurapov
previously approved these changes
Nov 12, 2024
oana-lolea
previously approved these changes
Nov 13, 2024
njlie
force-pushed
the
nl/3029/auth-interaction-errors
branch
from
1735c6e
to
0282619
Compare
njlie
commented
Nov 13, 2024
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/gnap-error' |
There was a problem hiding this comment.
I figured it might make sense to include this in the auth server spec as well for Open Payments, so I captured it in an issue here.
oana-lolea
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
gnapServerErrorMiddlewareto the routes on the Identity Provider API on the auth server.Context
Closes #3029.
This ended up being a one-line change, as the IDP responses were added already in the spec from #850 and #3024. The code already throws these errors and had tests added as of #2400. There was one potential response missing from the spec, however.
Checklist
fixes #numberuser-docslabel (if necessary)