Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): pin base image to node 16.17.1 #674

Merged
merged 1 commit into from
Oct 17, 2022
Merged

chore(docker): pin base image to node 16.17.1 #674

merged 1 commit into from
Oct 17, 2022

Conversation

wilsonianb
Copy link
Contributor

@wilsonianb wilsonianb commented Oct 14, 2022 •
edited
Loading

Changes proposed in this pull request

Use previous node:16-slim image (instead of the latest 16.18.0), in order to (temporarily) maximize Docker build cache usage

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. labels Oct 14, 2022
@wilsonianb wilsonianb marked this pull request as ready for review October 14, 2022 18:00
uchibeke
uchibeke approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@uchibeke uchibeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilsonianb wilsonianb merged commit c5bd577 into main Oct 17, 2022
@wilsonianb wilsonianb deleted the bw-fix-docker branch October 17, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@uchibeke uchibeke uchibeke approved these changes

@njlie njlie Awaiting requested review from njlie

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilsonianb @uchibeke @mkurapov