-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): use node:18-slim base image #728
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c7b16c5
chore(ci): build Docker platforms separately
wilsonianb 7eb12e3
chore(docker): use node:18-slim base image
wilsonianb 8b1c97a
chore(docs): update README setup instructions
wilsonianb e01a337
chore(ci): consolidate docker workflows
wilsonianb 18a8054
chore(ci): exclude arm64 Docker builds for pull requests
wilsonianb fc79e3c
chore(docker): specify base image minor and patch version
wilsonianb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
FROM node:16.17.1-slim as builder | ||
FROM node:18-slim as builder | ||
|
||
WORKDIR /workspace | ||
|
||
RUN apt update | ||
RUN apt install -y curl xz-utils python3 build-essential | ||
|
||
# version in curl is not the version used. Dependent on the last command | ||
RUN curl -f https://get.pnpm.io/v6.16.js | node - add --global [email protected] | ||
RUN corepack enable | ||
RUN corepack prepare [email protected] --activate | ||
|
||
# pnpm fetch does require only lockfile | ||
COPY pnpm-lock.yaml ./ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
FROM node:16.17.1-slim as builder | ||
FROM node:18-slim as builder | ||
|
||
WORKDIR /workspace | ||
|
||
RUN apt update | ||
RUN apt install -y curl xz-utils python3 build-essential | ||
|
||
# version in curl is not the version used. Dependent on the last command | ||
RUN curl -f https://get.pnpm.io/v6.16.js | node - add --global [email protected] | ||
RUN corepack enable | ||
RUN corepack prepare [email protected] --activate | ||
|
||
# pnpm fetch does require only lockfile | ||
COPY pnpm-lock.yaml ./ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
FROM node:16.17.1-slim as builder | ||
FROM node:18-slim as builder | ||
|
||
WORKDIR /workspace | ||
|
||
RUN apt update | ||
RUN apt install -y curl xz-utils python3 build-essential | ||
|
||
# version in curl is not the version used. Dependent on the last command | ||
RUN curl -f https://get.pnpm.io/v6.16.js | node - add --global [email protected] | ||
RUN corepack enable | ||
RUN corepack prepare [email protected] --activate | ||
|
||
# pnpm fetch does require only lockfile | ||
COPY pnpm-lock.yaml ./ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
FROM node:16-slim as builder | ||
FROM node:18-slim as builder | ||
|
||
WORKDIR /workspace | ||
|
||
RUN apt update | ||
RUN apt install -y curl xz-utils python3 build-essential | ||
|
||
# version in curl is not the version used. Dependent on the last command | ||
RUN curl -f https://get.pnpm.io/v6.16.js | node - add --global [email protected] | ||
RUN corepack enable | ||
RUN corepack prepare [email protected] --activate | ||
|
||
# pnpm fetch does require only lockfile | ||
COPY pnpm-lock.yaml ./ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,6 @@ | |
"typescript": "^4.9.4" | ||
}, | ||
"engines": { | ||
"node": "16 || 18" | ||
"node": "18" | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we specify a specific version to make use of the cache? I think
18-slim
resolves to the latest version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest
is actually19
now.https://hub.docker.com/_/node
Do you mean
node:18.13-slim
or specifying thesha256
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I meant the latest version of
18
. I was actually thinking of something like18.13.0-slim
to have a very specific version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that.
Can we get renovatebot to help us update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.renovatebot.com/modules/manager/dockerfile/#open-feature-requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the guy who wanted to do the pinning feature hasn't gotten to it yet.