Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix index error when values exceed 999T #581

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix ruff format
Signed-off-by: Fabian Degen <fabian.degen@mytum.de>
Fabian Degen committed Oct 24, 2024
commit adb823d4e1e69eea27aca83342ece104ae5377ff
4 changes: 1 addition & 3 deletions python/interpret-core/interpret/visual/plot.py
Original file line number Diff line number Diff line change
@@ -215,9 +215,7 @@ def _human_format(num):
while abs(num) >= 1000:
magnitude += 1
num /= 1000.0
return "{}{}".format(
f"{num:f}".rstrip("0").rstrip("."), suffixes[magnitude]
)
return "{}{}".format(f"{num:f}".rstrip("0").rstrip("."), suffixes[magnitude])


# TODO: Clean this up after validation.
10 changes: 6 additions & 4 deletions python/interpret-core/tests/visual/test_plot.py
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
from interpret.visual.plot import plot_line
from interpret.visual.plot import plot_density


def test_plot_line_bounds_smoke():
data_dict = {
"names": ["a", "b", "c"],
@@ -14,17 +15,18 @@ def test_plot_line_bounds_smoke():
figure = plot_line(data_dict)
assert figure.data[0].name == "Lower Bound"


def test_plot_density_large_numbers():
"""
Test that density plots handle large numbers correctly using the new number formatting
"""
data_dict = {
"scores": [1.0, 1.0],
"names": [9e13, 1e14, 1e15] # 1e15 value will trigger new formatting
"names": [9e13, 1e14, 1e15], # 1e15 value will trigger new formatting
}

figure = plot_density(data_dict)

# The x-axis tick text should show ranges using our new formatting
assert "90T - 100T" in figure.layout.xaxis.ticktext[0]
assert "100T - 1.00e+15" in figure.layout.xaxis.ticktext[1]
assert "100T - 1.00e+15" in figure.layout.xaxis.ticktext[1]