Skip to content

Commit

Permalink
Refs #69. Reverted removal of unused webengine libraries since this w…
Browse files Browse the repository at this point in the history
…as causing issues with code signing.
  • Loading branch information
SBriere committed Jul 20, 2022
1 parent cc1fa1e commit a23aabc
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ if(APPLE)
"Contents/Frameworks/PySide6/Qt/lib/QtQmlModels.framework/Versions/A/QtQmlModels"
"Contents/Frameworks/PySide6/Qt/lib/QtQuick.framework/Versions/A/QtQuick"
"Contents/Frameworks/PySide6/Qt/lib/QtWebChannel.framework/Versions/A/QtWebChannel"
# "Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/QtWebEngineCore"
"Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/QtWebEngineCore"
)

set(sign_libs)
Expand All @@ -181,9 +181,10 @@ if(APPLE)
)
endforeach()
# Sign web engine with specific entitlements
# Not working correctly for now - fix me!
# Not working correctly for now - fix me - issue is that we are "deep" signing, and thus overwritting the entitlement file.
# Solution is probably to manually generate a list of files to sign and manually sign them...
list(APPEND sign_libs
# COMMAND codesign --force -s ${MACSIGNID} --deep --options=runtime --timestamp --entitlements ${CMAKE_CURRENT_SOURCE_DIR}/../setup/QtWebEngineProcess.entitlements -v ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app
COMMAND codesign --force -s ${MACSIGNID} --deep --options=runtime --timestamp --entitlements ${CMAKE_CURRENT_SOURCE_DIR}/../setup/QtWebEngineProcess.entitlements -v ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app
COMMAND codesign --force -s ${MACSIGNID} --deep --options=runtime --timestamp --entitlements ${CMAKE_CURRENT_SOURCE_DIR}/../setup/QtWebEngineProcess.entitlements -v ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess
)

Expand All @@ -206,8 +207,8 @@ if(APPLE)
COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/../setup/prepare_to_sign.sh

# Since webengine isn't working for now, removing from final package to reduce size
COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/QtWebEngineCore
COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/MacOS/QtWebEngineCore
# COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/Frameworks/PySide6/Qt/lib/QtWebEngineCore.framework/Versions/A/QtWebEngineCore
# COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app/Contents/MacOS/QtWebEngineCore

${sign_libs}
COMMAND codesign --force -s ${MACSIGNID} --deep --options=runtime --timestamp -v ${CMAKE_CURRENT_SOURCE_DIR}/dist/OpenIMU.app
Expand Down

0 comments on commit a23aabc

Please sign in to comment.