Building commit file path from repo root instead of execution dir #2456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Modified
packages/core/src/git.ts
so thatgetGitLog
returns a list of commit object with the modified files path resolved from the root of the git repository instead of the execution directory.Why
Commits objects were built with
auto/packages/core/src/git.ts
Line 388 in 335fadb
But the documentation of path.resolve states:
Since it was only passing the file path returned by git log (which is a relative path) there was no absolute path generated and it would hence append the current directory (i.e the directory from where
auto
is run from) as a prefix to what git log returned. Meaning this would produce the correct absolute path only ifauto
is run from the root of the repository.Todo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major