Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include search params in edit next URL when coming from list #1318

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

nas-tabchiche
Copy link
Contributor

I purposefully did not include next urls coming from detail views as it requires additional testing.
Including url search params in next urls coming from list views is safe however, as search params are only used for filtering in list views.

@nas-tabchiche nas-tabchiche marked this pull request as draft January 7, 2025 09:44
@nas-tabchiche nas-tabchiche marked this pull request as ready for review January 7, 2025 10:21
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k

@Mohamed-Hacene Mohamed-Hacene merged commit e1d9807 into main Jan 7, 2025
17 checks passed
@Mohamed-Hacene Mohamed-Hacene deleted the include-search-params-in-next-url-from-list branch January 7, 2025 11:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants