Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display a count of "updatable" loaded libraries and allow their filtering #1396

Conversation

Mohamed-Hacene
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene commented Jan 22, 2025

Summary by CodeRabbit

  • New Features

    • Added localization support for "Yes", "No", and "Update Available" in English and French
    • Introduced library update filtering functionality
    • Added badge to display count of libraries with available updates
  • Localization

    • Updated language files with new translation keys
    • Enhanced user interface with multilingual support
  • User Interface

    • Improved library management view with update availability indicators

Copy link

coderabbitai bot commented Jan 22, 2025

Walkthrough

This pull request introduces localization enhancements and update tracking functionality for library management. The changes include adding new translation keys for 'yes', 'no', and 'update available' in English and French language files. In the table utility, a new filter configuration is implemented to allow filtering libraries based on update availability. The libraries page is updated to display a count of libraries with available updates, providing users with more informative interface elements about potential library updates.

Changes

File Change Summary
frontend/messages/en.json Added translations for 'yes', 'no', and 'updateAvailable'
frontend/messages/fr.json Added French translations for 'yes', 'no', and 'updateAvailable'
frontend/src/lib/utils/table.ts Added HAS_UPDATE_FILTER for filtering libraries with updates
frontend/src/routes/(app)/(internal)/libraries/+page.svelte Added availableUpdatesCount reactive variable to track libraries with updates

Sequence Diagram

sequenceDiagram
    participant User
    participant LibrariesPage
    participant LibrariesData
    participant UpdateFilter

    User->>LibrariesPage: View Libraries
    LibrariesPage->>LibrariesData: Fetch Libraries
    LibrariesData-->>LibrariesPage: Return Library Data
    LibrariesPage->>UpdateFilter: Apply Update Availability Filter
    UpdateFilter-->>LibrariesPage: Filtered Libraries
    LibrariesPage->>User: Display Libraries with Update Badge
Loading

Poem

🐰 Hop, hop, updates are here to cheer!
Libraries dancing, progress drawing near
Yes or no, the choice is clear
Badges sparkle, updates appear
A rabbit's guide to software's frontier! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d0a017 and 6494294.

📒 Files selected for processing (4)
  • frontend/messages/en.json (1 hunks)
  • frontend/messages/fr.json (1 hunks)
  • frontend/src/lib/utils/table.ts (2 hunks)
  • frontend/src/routes/(app)/(internal)/libraries/+page.svelte (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • frontend/messages/fr.json
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: startup-functional-test (3.12)
  • GitHub Check: startup-docker-compose-test
  • GitHub Check: enterprise-startup-functional-test (3.12)
  • GitHub Check: migrations-check (3.12)
  • GitHub Check: enterprise-startup-docker-compose-test
  • GitHub Check: enterprise-functional-tests (3.12, chromium)
  • GitHub Check: functional-tests (3.12, chromium)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (5)
frontend/src/routes/(app)/(internal)/libraries/+page.svelte (2)

20-22: LGTM! The reactive variable is well implemented.

The reactive variable correctly filters and counts libraries with available updates by checking the has_update property in the meta data.


36-40: LGTM! The badge is well implemented.

The badge is:

  • Conditionally rendered when updates are available
  • Uses appropriate styling with variant-soft-success
  • Includes a clear icon indicator
frontend/src/lib/utils/table.ts (2)

314-326: LGTM! The filter configuration is well implemented.

The filter:

  • Correctly uses the SelectFilter component
  • Maps boolean values to localized strings using yes/no keys
  • Includes appropriate display settings with alwaysDisplay: true

648-649: LGTM! The filter is correctly added to the loaded-libraries configuration.

The filter is properly integrated into the existing configuration alongside the other filters.

frontend/messages/en.json (1)

1128-1130: LGTM! The translations are well implemented.

The new translation keys:

  • Use clear and concise language
  • Follow the existing casing pattern
  • Are logically placed in the file
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ab-smith ab-smith changed the title feat: display a count of loaded libraries that have an update available and allow filtering against these feat: display a count of "updatable" loaded libraries and allow their filtering Jan 22, 2025
Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@nas-tabchiche nas-tabchiche merged commit b9b60ec into main Jan 22, 2025
18 checks passed
@nas-tabchiche nas-tabchiche deleted the CA-821-Display-a-count-of-loaded-libraries-that-have-an-update-available-and-allow-filtering-against-these branch January 22, 2025 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants