-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document PUBLIC_API_EXPOSED_URL #1429
Conversation
WalkthroughThe pull request updates the README.md file by adding documentation for the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
442-443
: Enhance the documentation with more details.Consider adding:
- Whether this is a required variable for SSO
- Example values (e.g., if CISO_ASSISTANT_URL is "https://example.com", then PUBLIC_BACKEND_API_EXPOSED_URL should be "https://example.com/api")
- The impact if not set correctly
-The PUBLIC_BACKEND_API_EXPOSED_URL is necessary for proper functioning of the SSO. It points to the URL of the API as seen from the browser. It should be equal to the concatenation of CISO_ASSISTANT_URL (in the backend) with "/api". +# Required for SSO functionality +export PUBLIC_BACKEND_API_EXPOSED_URL=<CISO_ASSISTANT_URL>/api +# Example: If CISO_ASSISTANT_URL=https://example.com, then PUBLIC_BACKEND_API_EXPOSED_URL=https://example.com/api +# This variable is required for Single Sign-On (SSO) to function properly, as it defines the API endpoint URL +# that the browser uses to communicate with the backend. If not set correctly, SSO authentication will fail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: startup-functional-test (3.12)
- GitHub Check: startup-docker-compose-test
- GitHub Check: enterprise-startup-functional-test (3.12)
- GitHub Check: functional-tests (3.12, chromium)
- GitHub Check: enterprise-functional-tests (3.12, chromium)
- GitHub Check: enterprise-startup-docker-compose-test
🔇 Additional comments (1)
README.md (1)
442-443
:⚠️ Potential issueInconsistent variable name in PR title vs documentation.
The PR title mentions
PUBLIC_API_EXPOSED_URL
but the documentation usesPUBLIC_BACKEND_API_EXPOSED_URL
. Please ensure consistency to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0k
Summary by CodeRabbit
PUBLIC_BACKEND_API_EXPOSED_URL
environment variable