perf: improve query for threats radar

[ab-smith]

Summary by CodeRabbit

• New Features

  • Enhanced threat counting functionality with improved type hinting
  • Optimized threat scenario counting using Django ORM annotations

• Refactor

  • Streamlined threat counting process
  • Improved method signature with explicit return type

[coderabbitai]

Walkthrough

The pull request modifies the threats_count_per_name function in the backend's core helpers module. The changes focus on improving type hinting, refactoring the threat counting mechanism using Django's annotate method, and optimizing the query to count risk scenarios associated with threats. The updated implementation ensures more efficient and precise counting of threats, with a clearer return type specification.

Changes

File	Change Summary
backend/core/helpers.py	- Added Dict and List imports from typing module - Updated function signature with explicit return type annotation - Refactored threat counting logic using Django's annotate method - Implemented filtered counting of risk scenarios per threat

Poem

🐰 A Rabbit's Ode to Query Refinement

With Django's magic, annotations shine bright,
Counting threats with precision and might
Type hints dancing, clear as can be
Efficiency leaps, our code now set free!
🔍✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2e4b9c and 4b8f122.

📒 Files selected for processing (1)

• backend/core/helpers.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: startup-functional-test (3.12)
• GitHub Check: functional-tests (3.12, chromium)
• GitHub Check: startup-docker-compose-test
• GitHub Check: enterprise-functional-tests (3.12, chromium)
• GitHub Check: enterprise-startup-functional-test (3.12)
• GitHub Check: test (3.12)
• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: ruff (3.12)
• GitHub Check: build (3.12)
• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

backend/core/helpers.py (3)

5-5: LGTM!

The import of Dict and List from typing module is correctly placed and properly used for type hinting.

---

1143-1163: Great optimization of the query performance!

The changes improve the efficiency by:

1. Using Django's annotate with Count to perform counting at the database level
2. Properly filtering for accessible scenarios
3. Using consistent field naming (risk_scenarios)
4. Adding type hints for better code maintainability

The query is now more performant as it avoids N+1 queries.

---

1165-1168: Good improvement to the data structure!

The changes enhance the output by:

1. Structuring the data consistently
2. Adding max offset to improve visibility in the UI
3. Maintaining proper ordering by threat name

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.