Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a filter on current and residual risk levels on risk scenarios #1442

Conversation

Axxiar
Copy link
Contributor

@Axxiar Axxiar commented Jan 28, 2025

Add a filter on current and residual risk levels on risk scenarios model table view

Summary by CodeRabbit

  • New Features
    • Enhanced list view filtering for risk scenarios
    • Added ability to filter by current and residual risk levels
    • Improved user experience with more granular filtering options

Copy link

coderabbitai bot commented Jan 28, 2025

Walkthrough

The pull request introduces two new filter configurations in the frontend/src/lib/utils/table.ts file for the risk-scenarios section. These filters, CURRENT_LEVEL_FILTER and RESIDUAL_LEVEL_FILTER, utilize the SelectFilter component to enable filtering based on current and residual levels. The new filters are designed to enhance the list view's filtering capabilities by allowing users to filter rows based on specific level attributes.

Changes

File Change Summary
frontend/src/lib/utils/table.ts Added two new filter configurations: CURRENT_LEVEL_FILTER and RESIDUAL_LEVEL_FILTER for risk-scenarios section

Suggested Reviewers

  • eric-intuitem

Poem

🐰 Filters hopping, levels in sight,
Two new friends join the table's might
Current and residual, they dance with glee
Filtering rows with rabbit-like spree
Code evolves, complexity takes flight! 🌟

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/src/lib/utils/table.ts (1)

479-481: Consider grouping related filters together.

For better organization and user experience, consider grouping risk-related filters together. Move current_level and residual_level filters next to other risk-related filters like treatment.

 filters: {
   folder: { ...DOMAIN_FILTER_FROM_PROJECT, alwaysDisplay: true },
   project: { ...PROJECT_FILTER, alwaysDisplay: true },
   treatment: { ...TREATMENT_FILTER, alwaysDisplay: true },
+  current_level: CURRENT_LEVEL_FILTER,
+  residual_level: RESIDUAL_LEVEL_FILTER,
   risk_assessment: RISK_ASSESSMENT_FILTER,
   threats: THREAT_FILTER,
-  assets: ASSET_FILTER,
-  current_level: CURRENT_LEVEL_FILTER,
-  residual_level: RESIDUAL_LEVEL_FILTER
+  assets: ASSET_FILTER
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9dd846b and b0dc534.

📒 Files selected for processing (1)
  • frontend/src/lib/utils/table.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: enterprise-startup-functional-test (3.12)
  • GitHub Check: startup-functional-test (3.12)
  • GitHub Check: functional-tests (3.12, chromium)
  • GitHub Check: startup-docker-compose-test
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: migrations-check (3.12)
  • GitHub Check: enterprise-startup-docker-compose-test
  • GitHub Check: enterprise-functional-tests (3.12, chromium)
🔇 Additional comments (1)
frontend/src/lib/utils/table.ts (1)

231-247: Add null checks for nested properties.

The getColumn functions assume that current_level and residual_level always exist and have a name property. This could lead to runtime errors if these properties are undefined.

Let's verify if these properties can be null/undefined:

@ab-smith ab-smith changed the title feat: add a filter on current & residual risk levels on risk scenarios feat: add a filter on current and residual risk levels on risk scenarios Jan 28, 2025
@ab-smith ab-smith self-requested a review January 28, 2025 19:34
@ab-smith ab-smith merged commit 73570ee into main Jan 28, 2025
18 checks passed
@ab-smith ab-smith deleted the CA-841-add-a-filter-on-current-and-residual-risk-levels-on-risk-scenarios-model-table-view branch January 28, 2025 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants