-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct cronjob for huey #1471
Conversation
WalkthroughThe change updates the cron expression used to schedule the Changes
Sequence Diagram(s)sequenceDiagram
participant CR as Cron Scheduler
participant DP as DB Periodic Task Decorator
participant TC as check_controls_with_expired_eta
CR->>DP: At 6:00 AM (hour: "6", minute: "0") trigger
DP->>TC: Invoke scheduled task
TC-->>DP: Task execution completed
Poem
Tip 🌐 Web search-backed reviews and chat
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
backend/core/tasks.py (1)
20-20
: Consider adding a comment to document the schedule.Add a comment above the decorator to document when this task runs and why, making it easier for other developers to understand the scheduling decision.
+# Run daily at 6:00 AM to check for expired controls and send notifications @db_periodic_task(crontab(hour="6", minute="0"))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
backend/core/tasks.py
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: startup-functional-test (3.12)
- GitHub Check: startup-docker-compose-test
- GitHub Check: enterprise-startup-functional-test (3.12)
- GitHub Check: enterprise-functional-tests (3.12, chromium)
- GitHub Check: enterprise-startup-docker-compose-test
- GitHub Check: ruff (3.12)
- GitHub Check: functional-tests (3.12, chromium)
- GitHub Check: build (3.12)
- GitHub Check: test (3.12)
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
backend/core/tasks.py (1)
20-20
: LGTM! The cron schedule is now more precise.The change ensures the task runs exactly at 6:00 AM instead of at a random minute during the 6 AM hour, making the execution time more predictable and easier to monitor.
Summary by CodeRabbit