Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specificity of input[type="search"] box-sizing #8

Closed
niksurff opened this issue Oct 15, 2015 · 7 comments
Closed

specificity of input[type="search"] box-sizing #8

niksurff opened this issue Oct 15, 2015 · 7 comments

Comments

@niksurff
Copy link

I was styling a search field today and relied on it being set to box-sizing: border-box.
I noticed that input[type="search"] box-sizing rule trumps the generic rules in inuit-box-sizing.
I ended up setting the rule in my component class, which is all right but not expected.

Any thoughts? - Thanks.

@csshugs
Copy link
Member

csshugs commented Oct 15, 2015

@nikvm It seems, this wont be "fixed" in the original repo, as discussed here which is a shame I think. I've gone through this issue too, having to override it myself with border-box. Due to the fact that this is just a copy of the official normalize.css, we need to live with it.

Though I think this is something we need to override ourselves in every project and could probably go into something like _reset.scss in the base layer, e.g.

input[type="search"] {
    box-sizing: border-box;
}

@necolas
Copy link

necolas commented Jan 5, 2016

I'd merge a patch for this normalize issue; agree that it's annoying / wrong.

@csshugs
Copy link
Member

csshugs commented Jan 5, 2016

Ah that's great news and a big relief. Thanks @necolas for addressing this issue!

@csshugs
Copy link
Member

csshugs commented Jan 22, 2016

Just for the records: The above mentioned patch is being applied

@csshugs
Copy link
Member

csshugs commented Mar 23, 2016

For the records again: Version 4.0.0 of normalize.css has landed. In that version, this issue is being addressed:

Remove unnecessary box-sizing for input[type="search"] in Chrome, Edge, Firefox, IE, and Safari

With #10, there is already a PR to update to version 4.0.0. When #10 is merged, this issue can be closed.

@csshugs
Copy link
Member

csshugs commented Jun 22, 2016

@nikvm or @anselmh :
#10 is merged. Can you close this issue?

@anselmh anselmh closed this as completed Jun 22, 2016
@csshugs
Copy link
Member

csshugs commented Jun 22, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants