Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box-sizing issue with input[type="search"] #471

Closed
patrickhlauke opened this issue Aug 28, 2015 · 8 comments
Closed

box-sizing issue with input[type="search"] #471

patrickhlauke opened this issue Aug 28, 2015 · 8 comments

Comments

@patrickhlauke
Copy link
Contributor

-webkit-box-sizing: content-box;
box-sizing: content-box;

appears to be making search inputs wider than they should be - see twbs/bootstrap#17379

@BYODKM
Copy link

BYODKM commented Sep 1, 2015

#358

@patrickhlauke
Copy link
Contributor Author

So, maybe @necolas can confirm (as I just read through the linked issues there, with their very terse comments): is the fact that box-sizing: content-box results in search inputs being larger than their equivalent text inputs intentional then, and won't be fixed? /cc @cvrebert

@BYODKM
Copy link

BYODKM commented Sep 2, 2015

Normalize.css is for normalize browsers' default style. Which means you can not always get what you want. You can have a small reset css for input[type=search] in your own project as usual. The same as the h1, fieldset and so on.

@patrickhlauke
Copy link
Contributor Author

How about normalizing it to what should be the default, according to https://www.w3.org/Bugs/Public/show_bug.cgi?id=28784 ? I'm fine overriding it myself, but effectively here you're normalizing it against all current consistent (with exception of Firefox, but that's being fixed now too) default styling in browsers...

@FagnerMartinsBrack
Copy link

I am watching this repository for a long time, and as far as I know there was no discussion regarding search inputs being wider than they should be. Most discussions regarding that style is about it being harder to override, because one can't just include normalize and go for * { box-sizing: border-box; } and expect the search inputs to be overriden.

Other than that this seems pretty legit and worth looking into, as long as it doesn't cause a regression from the first bullet point.

@patrickhlauke
Copy link
Contributor Author

As there seems to be little interest here in addressing this, closing. We fixed it back to browser defaults in Bootstrap, FWIW.

@necolas
Copy link
Owner

necolas commented Jan 5, 2016

Sorry for being absent. I agree that this is an annoying quirk of normalize that should be fixed. It looks like the original reasoning doesn't stand up, and I'd rather be pragmatic about it anyway.

@patrickhlauke
Copy link
Contributor Author

Sorry for interpreting silence for lack of interest/agreement. Wasn't sure how best to formulate a visual test, but gave it a go in the PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants