Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dims keyword to identify axis to use #58

Open
rofinn opened this issue Mar 21, 2021 · 1 comment
Open

Use dims keyword to identify axis to use #58

rofinn opened this issue Mar 21, 2021 · 1 comment

Comments

@rofinn
Copy link
Member

rofinn commented Mar 21, 2021

For HoD, Periodic, OneHotEncoding we should be able to reuse the dims keyword to apply the transformation to the axis values. I don't think the user should explicitly need to do KeyedArray(Periodic(sin, Day(1))(a.time); time=a.time) just to get a KeyedVector back with the original time axis.

@glennmoy
Copy link
Member

This feels like it would be an inconsistent use of dims compared to the rest of the package, which uses it as an arg in selectdim. But I'm sure we can do something about it.

Also, just leaving this as reference for now as there may be further relevant conversation here:
#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants