Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
I'll note that #20 describes the situation before we deprecated both
eachslice
(#15) andmapslices
(#45) in the parentapply
methods. So the problem it is describing is outdated since we no longer need to take the complement set of dimensions for any transformations.Still it is important that we support
dimnames
since user feedback suggested "Not having named dims limits the usefulness of using a KeyedArray as opposed to just an AbstractArray". Fortunately, we already support this, this PR is just making that explicit via the tests.However
inds
(for now, we might support this in future)AxisArrays
first supportingselectdim
. Considering we failed to getmapslices
into AxisArrays I'm not in a rush to support it as we'll be dropping it internally altogether soon enough.