-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No-arg MeanStdScaling
constructor
#59
Comments
@bencottier might also remember, but I think one reason we favoured immutable struct was to prevent the user from recycling the same But I guess we could allow mutability iff the fields are |
The other reason was saving code. We'd need to overload |
A no-arg
As @mzgubic points out, this requires separating out the constructor and the fitting |
In many cases, we're gonna call
apply
with the same array data that was used to construct theMeanstdScaling
transform, so why not provide a no-arg constructor and computing themean
andstd
on the fly in theapply
call? I guess that would make the fieldsUnion{Real, Nothing}
.The text was updated successfully, but these errors were encountered: