-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StandardScaling
with separate constructor and fit methods to replace MeanStdScaling
#107
Conversation
4dd5a9a
to
b939659
Compare
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 98.74% 98.88% +0.14%
==========================================
Files 13 15 +2
Lines 159 179 +20
==========================================
+ Hits 157 177 +20
Misses 2 2
Continue to review full report at Codecov.
|
In general I'm in favour of these changes - I just don't think we should extend Oh and we should also document |
Co-authored-by: Glenn Moynihan <[email protected]>
StandardScaling
with separate constructor and fit methods to replace MeanStdScaling
StandardScaling
with separate constructor and fit methods to replace MeanStdScaling
Thank you both for reviewing, I think it's ready to go now. We went with the mutable approach so as not to inflate the API with an extra |
Closes #106, closes #59, closes #87
This is made non-breaking by deprecating the
MeanStdScaling
.To do:
fit!
in the docs