Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform interface and example Power transformation #1

Merged
merged 17 commits into from
Feb 2, 2021

Conversation

glennmoy
Copy link
Member

@glennmoy glennmoy commented Jan 26, 2021

PoC for the package interface (modelled off Impute.jl) and a prototype transform.

@rofinn
Copy link
Member

rofinn commented Jan 27, 2021

I feel like maybe this package should be called Transforms.jl so that we can just have a Transform type?

@glennmoy
Copy link
Member Author

glennmoy commented Jan 27, 2021

I feel like maybe this package should be called Transforms.jl so that we can just have a Transform type?

Yeah perhaps that's better

Edit: I've now changed the name of the package and updated all references in the code.

src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
test/power.jl Show resolved Hide resolved
src/power.jl Outdated Show resolved Hide resolved
Copy link
Member

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, though I'm obviously biased. I think some more extensive testing and sample transforms would help. We may also need to do some iteration on the kwargs and function names at a later time.

src/transformers.jl Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/power.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
test/power.jl Show resolved Hide resolved
src/Transform.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Show resolved Hide resolved
Co-authored-by: Ben Cottier <[email protected]>
@glennmoy glennmoy changed the title WIP: Transform interface and example Power transformation Transform interface and example Power transformation Feb 1, 2021
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Show resolved Hide resolved
test/power.jl Outdated Show resolved Hide resolved
Glenn Moynihan added 4 commits February 1, 2021 17:45
Although this is the current LTS we expect to make a lot of use of
eachslice in the package which was only introduced in 1.1.

Furthermore, the upcoming 1.6 release will be the new LTS.
@glennmoy glennmoy merged commit 3fe2b27 into main Feb 2, 2021
@glennmoy glennmoy deleted the gm/wip_interface branch February 2, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants