Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test dependency on DataFrames update compat #103

Merged
merged 1 commit into from
Aug 25, 2021
Merged

test dependency on DataFrames update compat #103

merged 1 commit into from
Aug 25, 2021

Conversation

mzgubic
Copy link
Contributor

@mzgubic mzgubic commented Aug 25, 2021

Nightly CI on Julia 1.3 started failing last night (I don't know what change caused it) but essentially the issue is that on older julia versions the package resolver is not willing to downgrade test-time packages only, see more detail here: https://www.oxinabox.net/2021/02/13/Julia-1.6-what-has-changed-since-1.0.html#resolver-willing-to-downgrade-packages-to-install-new-ones-tiered-resolution

It turns out that we can simply update the DataFrames compat to 1 to fix it.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #103 (ecce922) into main (cd4e2e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          12       12           
  Lines         143      143           
=======================================
  Hits          141      141           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4e2e9...ecce922. Read the comment docs.

@thomasgudjonwright
Copy link

Sorry if I am misunderstanding, but if 0.22 is problematic should it not be removed from the compat?

@mzgubic
Copy link
Contributor Author

mzgubic commented Aug 25, 2021

It's sort of complicated, there are a bunch of things to consider.

We only specify compat for the things that would actually break in this package, and since this package (at test time) uses only the basic DataFrames interface, it is compatible with both 0.22 and 1. We don't care if our package depends on a package that breaks in 0.22 - it is that package's job to figure out it's own compat bounds.

What actually happened here though was not that there was anything broken in 0.22. It's just that in old julia versions the package manager was not smart enough to deal with test-only dependencies. It would first build the main environment, and when adding the extra test-only dependencies not willing to downgrade one of the main dependencies.

Copy link

@thomasgudjonwright thomasgudjonwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that makes sense!

@mzgubic mzgubic merged commit d220481 into main Aug 25, 2021
@mzgubic mzgubic deleted the mz/compat branch August 25, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants