Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Julia 1.5 and older #110

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Drop support for Julia 1.5 and older #110

merged 1 commit into from
Aug 4, 2022

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Aug 3, 2022

This seemed like the easier options since Documenter dropped these Julia version a couple weeks ago and is now causing compat issues.

https://github.com/invenia/FeatureTransforms.jl/actions/runs/2786559009

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #110 (3b81125) into main (4a636c8) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   98.90%   98.87%   -0.04%     
==========================================
  Files          15       14       -1     
  Lines         183      178       -5     
==========================================
- Hits          181      176       -5     
  Misses          2        2              
Impacted Files Coverage Δ
src/apply.jl 100.00% <0.00%> (ø)
src/periodic.jl 100.00% <0.00%> (ø)
src/one_hot_encoding.jl 100.00% <0.00%> (ø)
src/FeatureTransforms.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rofinn
Copy link
Member Author

rofinn commented Aug 3, 2022

Looks like coverage reporting might be different across Julia releases? Also, I think the Julia 1.5 jobs is stuck cause it's required on main? I believe that should go away once merged?

@Wynand
Copy link

Wynand commented Aug 3, 2022

This seems to work when the Julia 1.5 test isn't included: https://github.com/invenia/FeatureTransforms.jl/actions/runs/2791698474

And coverage seems to only be an issue because there are 5 less lines of code: https://github.com/invenia/FeatureTransforms.jl/pull/110/checks?check_run_id=7658996965

Copy link
Contributor

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with dropping support for 1.5.

@rofinn rofinn merged commit cc299dc into main Aug 4, 2022
@rofinn rofinn deleted the rf/julia-1.6 branch August 4, 2022 15:25
@AlexRobson
Copy link
Member

Small question - Is this actually a non-breaking release?

I had done something similar for 0.3 for NamedDims and someone commented that it's a minor release.

invenia/NamedDims.jl#202 (comment)

(I've got to here because I'm trying to see which packages need NamedDims 1 and I also encountered this package due to a resolution issue from one of our internal packages)

@mzgubic
Copy link
Contributor

mzgubic commented Sep 23, 2022

Small question - Is this actually a non-breaking release?

Yes, indeed it is, sorry if it caused trouble. I imagine it can be resolved by bumping compat in a few places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants