Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test application of IdentityScaling() does nothing #113

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

mjp98
Copy link
Member

@mjp98 mjp98 commented Oct 31, 2022

Perhaps this could be tested for each type of input in tests/types?

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #113 (566c9b2) into main (cc299dc) will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   98.90%   99.45%   +0.54%     
==========================================
  Files          14       14              
  Lines         182      182              
==========================================
+ Hits          180      181       +1     
+ Misses          2        1       -1     
Impacted Files Coverage Δ
src/scaling.jl 100.00% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we could add one or two other cases, but there is no need to test exhaustively.

@glennmoy glennmoy merged commit ee13296 into main Oct 31, 2022
@glennmoy glennmoy deleted the mjp/test-identity-transform branch October 31, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants