Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HoD transform #16

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Add HoD transform #16

merged 2 commits into from
Feb 12, 2021

Conversation

nicoleepp
Copy link
Contributor

Part of #6

Supersedes #11

@nicoleepp nicoleepp mentioned this pull request Feb 11, 2021
4 tasks
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #16 (e79b2fc) into main (670f4b3) will decrease coverage by 0.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   93.58%   92.64%   -0.95%     
==========================================
  Files           6        7       +1     
  Lines          78       68      -10     
==========================================
- Hits           73       63      -10     
  Misses          5        5              
Impacted Files Coverage Δ
src/Transforms.jl 100.00% <ø> (ø)
src/temporal.jl 100.00% <100.00%> (ø)
src/transformers.jl 95.23% <0.00%> (-0.60%) ⬇️
src/power.jl 100.00% <0.00%> (ø)
src/periodic.jl 100.00% <0.00%> (ø)
src/linear_combination.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670f4b3...e79b2fc. Read the comment docs.

Copy link
Contributor

@bencottier bencottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just spotted a couple typos in the tests.

test/temporal.jl Outdated Show resolved Hide resolved
test/temporal.jl Outdated Show resolved Hide resolved
test/temporal.jl Outdated Show resolved Hide resolved
test/temporal.jl Outdated Show resolved Hide resolved
@nicoleepp nicoleepp merged commit 0f49caa into main Feb 12, 2021
@nicoleepp nicoleepp deleted the ne/hod branch February 12, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants