Add OneHotEncoding Transform #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 93.75% 93.58% -0.17%
==========================================
Files 7 8 +1
Lines 80 78 -2
==========================================
- Hits 75 73 -2
Misses 5 5
Continue to review full report at Codecov.
|
nicoleepp
commented
Feb 17, 2021
bencottier
reviewed
Feb 17, 2021
src/one_hot_encoding.jl
Outdated
|
|
||
| function OneHotEncoding(possible_values::AbstractVector) | ||
| if length(unique(possible_values)) < length(possible_values) | ||
| throw(ArgumentError("Expected an ordered list of all unique possible values")) |
There was a problem hiding this comment.
Do the elements need to be a consistent order? Or does "ordered list" just refer to the type?
There was a problem hiding this comment.
They just need to be in the order of expected column output. so for input of 24 hours they should be ordered from Hour(1) to Hour(24). Then if it is applied on x = [Hour (2), Hour(2), Hour(1)] the result would be
0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
bencottier
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7