Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bool by default for OneHotEncoding Transform #31

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

nicoleepp
Copy link
Contributor

Closes #7

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #31 (714d654) into main (5bbb41b) will decrease coverage by 4.52%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   99.11%   94.59%   -4.53%     
==========================================
  Files           9        9              
  Lines         113      111       -2     
==========================================
- Hits          112      105       -7     
- Misses          1        6       +5     
Impacted Files Coverage Δ
src/power.jl 100.00% <ø> (ø)
src/temporal.jl 100.00% <ø> (ø)
src/utils.jl 37.50% <75.00%> (-50.00%) ⬇️
src/linear_combination.jl 100.00% <100.00%> (ø)
src/one_hot_encoding.jl 100.00% <100.00%> (ø)
src/periodic.jl 100.00% <100.00%> (ø)
src/scaling.jl 96.15% <100.00%> (-3.85%) ⬇️
src/transformers.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9249440...1f66395. Read the comment docs.

src/one_hot_encoding.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@bencottier bencottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think just edit the title e.g. "Use Bool by default for OneHotEncoding Transform".

src/one_hot_encoding.jl Show resolved Hide resolved
src/one_hot_encoding.jl Outdated Show resolved Hide resolved
@nicoleepp nicoleepp changed the title Switch to Bool for OneHotEncoding Transform Use Bool by default for OneHotEncoding Transform Feb 25, 2021
@nicoleepp nicoleepp merged commit 973c4e1 into main Feb 25, 2021
@nicoleepp nicoleepp deleted the ne/bool-ohe branch February 25, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One hot encoding transform
4 participants