Relax period and phase_shift type restrictions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must have the same supertype, but not necessarily the same concrete type
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 99.11% 95.09% -4.02%
==========================================
Files 9 9
Lines 113 102 -11
==========================================
- Hits 112 97 -15
- Misses 1 5 +4
Continue to review full report at Codecov.
|
glennmoy
approved these changes
Feb 24, 2021
glennmoy
reviewed
Feb 24, 2021
| return new{T}(f, period, phase_shift) | ||
| function Periodic(f, period::P, phase_shift::S) where {P, S} | ||
| if !((P <: Real && S <: Real) || (P <: Period && S <: Period)) | ||
| throw(ArgumentError("period and phase_shift must have the same supertype")) |
There was a problem hiding this comment.
I guess this gives a more informative error message compared to my suggestion which would have just been a MethodError.
Co-authored-by: Glenn Moynihan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
A couple of tweaks along the way:
ArgumentErrortoDomainErrorfor non-positive period, and test this forTimeTypeas well asRealP