Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to FeatureTransforms #33

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Rename package to FeatureTransforms #33

merged 2 commits into from
Feb 25, 2021

Conversation

glennmoy
Copy link
Member

@glennmoy glennmoy commented Feb 25, 2021

Following the discussion in JuliaRegistries/General#30630 (comment)

I opted for FeatureTransforms.jl to conceptually align the package name with the Transform type we've already implemented.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #33 (9d3000f) into main (6c43de4) will decrease coverage by 1.20%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   95.79%   94.59%   -1.21%     
==========================================
  Files           9        9              
  Lines         119      111       -8     
==========================================
- Hits          114      105       -9     
- Misses          5        6       +1     
Impacted Files Coverage Δ
src/utils.jl 37.50% <75.00%> (+37.50%) ⬆️
src/FeatureTransforms.jl 100.00% <100.00%> (ø)
src/linear_combination.jl 100.00% <100.00%> (ø)
src/one_hot_encoding.jl 100.00% <100.00%> (ø)
src/transformers.jl 100.00% <100.00%> (ø)
src/scaling.jl 96.15% <0.00%> (-0.52%) ⬇️
src/power.jl 100.00% <0.00%> (ø)
src/periodic.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973c4e1...55a4cb2. Read the comment docs.

@glennmoy glennmoy merged commit 7aef385 into main Feb 25, 2021
@nicoleepp nicoleepp deleted the gm/rename branch February 26, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants