Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple refactor #41

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Simple refactor #41

merged 3 commits into from
Mar 4, 2021

Conversation

glennmoy
Copy link
Member

@glennmoy glennmoy commented Mar 4, 2021

drive-by refactoring of some code

@glennmoy glennmoy changed the title Simply refactor Simple refactor Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #41 (362ff3e) into main (7aef385) will decrease coverage by 0.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   95.31%   94.59%   -0.72%     
==========================================
  Files           9        9              
  Lines         128      111      -17     
==========================================
- Hits          122      105      -17     
  Misses          6        6              
Impacted Files Coverage Δ
src/power.jl 100.00% <100.00%> (ø)
src/transformers.jl 100.00% <100.00%> (ø)
src/scaling.jl 96.15% <0.00%> (-0.52%) ⬇️
src/periodic.jl 100.00% <0.00%> (ø)
src/one_hot_encoding.jl 100.00% <0.00%> (ø)
src/linear_combination.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aef385...362ff3e. Read the comment docs.

@glennmoy glennmoy merged commit 081a9af into main Mar 4, 2021
@glennmoy glennmoy deleted the gm/simply_refactor branch March 9, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants