Refactor apply methods to use Traits #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmoy
commented
Apr 16, 2021
glennmoy
commented
Apr 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 11 11
Lines 122 123 +1
=======================================
+ Hits 121 122 +1
Misses 1 1
Continue to review full report at Codecov.
|
glennmoy
commented
Apr 16, 2021
glennmoy
commented
Apr 16, 2021
| @@ -60,7 +60,7 @@ | |||
| @testset "dims = :" begin | |||
| M = [1 1; 2 2; 3 5] | |||
| lc = LinearCombination([1, -1, 1]) | |||
| @test_throws ArgumentError FeatureTransforms.apply(M, lc; dims=:) | |||
| @test_deprecated FeatureTransforms.apply(M, lc; dims=:) | |||
There was a problem hiding this comment.
We have removed the default dims=1 for LinearCombination but added a deprecation warning so it's non-breaking for now.
glennmoy
commented
Apr 16, 2021
bencottier
reviewed
Apr 16, 2021
bencottier
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second step in #75
replaces #77
Note I haven't changed the LinearCombination tests to prevent this being a breaking change. Instead I added a deprecation warning if
dims=:is passed in.