Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use max rather than maximum to decide if need to use epislon #98

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

oxinabox
Copy link
Member

This saves on allocations

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #98 (8488424) into main (2c192ec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          12       12           
  Lines         143      143           
=======================================
  Hits          141      141           
  Misses          2        2           
Impacted Files Coverage Δ
src/scaling.jl 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c192ec...8488424. Read the comment docs.

Copy link
Member

@glennmoy glennmoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to bump the patch as well (since it's an internal optimisation?)

@oxinabox oxinabox merged commit 1d62a2a into main Jul 15, 2021
@oxinabox oxinabox deleted the ox/max branch July 15, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants