Merge pull request #134 from invenia/rf/validate-fallback

Validate fallback for non-missing vectors
invenia · Dec 19, 2022 · 9507123 · 9507123 · rofinn · Dec 19, 2022
2 parents abcc605 + 894344e
commit 9507123
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Impute"
 uuid = "f7bf1975-0170-51b9-8c5f-a992d46b9575"
 authors = ["Invenia Technical Computing"]
-version = "0.6.9"
+version = "0.6.10"
 
 [deps]
 BSON = "fbb218c0-5317-5bc6-957e-2ee96dd4b1f0"

diff --git a/src/validators.jl b/src/validators.jl
@@ -103,4 +103,6 @@ function validate(table, v::Validator; cols=nothing, kwargs...)
     return table
 end
 
+_validate(data::AbstractArray, v::Validator; kwargs...) = disallowmissing(data)
+
 include("validators/threshold.jl")
diff --git a/test/validators.jl b/test/validators.jl
@@ -42,6 +42,11 @@
         @test isequal(validate(m, t), m)
         @test isequal(validate(aa, t), aa)
         @test isequal(validate(table, t), table)
+
+        # Test type edge cases
+        @test_throws ThresholdError validate(fill(missing, 10), t)
+        @test validate(ones(10), t) == ones(10)
+        @test validate(ones(10), t) isa Vector{Float64}
     end
 
     @testset "Weighted" begin
@@ -66,6 +71,10 @@
 
         @test_throws DimensionMismatch validate(a[1:10], t)
         @test_throws DimensionMismatch validate(m[1:3, :], t; dims=:cols)
+
+        @test_throws ThresholdError validate(fill(missing, 5), t)
+        @test validate(ones(5), t) == ones(5)
+        @test validate(ones(5), t) isa Vector{Float64}
     end
 
     @testset "functional" begin